Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude deprecated from lowercase_definition check #1224

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Exclude deprecated from lowercase_definition check #1224

merged 4 commits into from
Nov 13, 2024

Conversation

jamesaoverton
Copy link
Member

@jamesaoverton jamesaoverton commented Nov 12, 2024 •
edited
Loading

Fixes #1220

  • docs/ have been added/updated
  • tests have been added/updated
  • mvn verify says all tests pass
  • mvn site says all JavaDocs correct
  • CHANGELOG.md has been updated

@jamesaoverton
Copy link
Member Author

This was failing because I forgot to define the owl prefix. It took me most of an hour to debug that (which is a bad sign). Then I spent another hour trying to find a clean way to improve that error reporting, and gave up in frustration.

matentzn
matentzn approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jamesaoverton jamesaoverton merged commit 27d5fd3 into master Nov 13, 2024
3 checks passed
@jamesaoverton jamesaoverton deleted the fix-1220 branch November 13, 2024 15:13
@jamesaoverton jamesaoverton mentioned this pull request Nov 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lowercase_definition check in robot report should not check obsolete terms
2 participants
@jamesaoverton @matentzn