Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve disambiguation of properties in QuotedEntityChecker #1226

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

jamesaoverton
Copy link
Member

@jamesaoverton jamesaoverton commented Nov 13, 2024

Addresses #1203, at least partially.

  • docs/ have been added/updated
  • tests have been added/updated
  • mvn verify says all tests pass
  • mvn site says all JavaDocs correct
  • CHANGELOG.md has been updated

@jamesaoverton jamesaoverton changed the title Improve disambiguation of properties in QUotedEntityChecker Improve disambiguation of properties in QuotedEntityChecker Nov 13, 2024
Copy link
Contributor

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Veeeery good to get this fixed, thank you!

@jamesaoverton jamesaoverton merged commit 0e688c1 into master Nov 14, 2024
3 checks passed
@jamesaoverton jamesaoverton deleted the improve-1203 branch November 14, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants