Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating ELK 0.43 to 0.5 #999

Merged
merged 9 commits into from
Sep 20, 2023
Merged

Updating ELK 0.43 to 0.5 #999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0c8e7a2
Update pom.xml
matentzn May 7, 2022
2582313
Update pom.xml
matentzn May 7, 2022
b63ae37
Merge branch 'master' into elk05
jamesaoverton Jan 12, 2023
7e26da4
Merge branch 'master' into elk05
matentzn Aug 5, 2023
5427759
Update ReasonerHelperTest.java
matentzn Aug 5, 2023
a805341
Fix ELK 0.5 test
matentzn Aug 7, 2023
49a569e
Update ReasonerHelperTest.java
matentzn Aug 7, 2023
5143656
Update pom.xml
matentzn Aug 7, 2023
8e375d5
Update CHANGELOG.md
matentzn Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- Updated ELK from 0.4.3 to 0.5.0. [#999]. This is an important change as ELK 0.5.0 is more complete than 0.4.3, which means that it will potentially uncover inferences, in particular unsatisfiable classes, which were not recognised by ELK 0.4.3.

## [1.9.4] - 2023-05-23

### Changed
Expand Down
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,9 @@
<version>1.7.32</version>
</dependency>
<dependency>
<groupId>org.semanticweb.elk</groupId>
<artifactId>elk-owlapi</artifactId>
<version>0.4.3</version>
<groupId>au.csiro</groupId>
<artifactId>elk-owlapi4</artifactId>
<version>0.5.0</version>
<exclusions>
<exclusion>
<groupId>log4j</groupId>
Expand Down
5 changes: 2 additions & 3 deletions robot-core/src/main/java/org/obolibrary/robot/ReasonerHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,8 @@ public class ReasonerHelper {
public static Set<OWLObjectProperty> getUnsatisfiableObjectProperties(OWLReasoner reasoner) {
Set<OWLObjectProperty> unsatObjectProps = new HashSet<>();

if (reasoner
.getPrecomputableInferenceTypes()
.contains(InferenceType.OBJECT_PROPERTY_HIERARCHY)) {
if (reasoner.getPrecomputableInferenceTypes().contains(InferenceType.OBJECT_PROPERTY_HIERARCHY)
&& !reasoner.getClass().getName().equals("org.semanticweb.elk.owlapi.ElkReasoner")) {
Copy link
Contributor Author

@matentzn matentzn Aug 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary because of liveontologies/elk-reasoner#66 (comment)

Basically, ELK 0.5 (as opposed to 0.43) claims to implement OBJECT_PROPERTY_HIERARCHY, but it does not recognise unsatisfiable object properties (or at least, not the one we are looking for in the test for incoherentRBox).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matentzn for tracking down the cause and for this solution! I'm glad that it didn't require reverting the faster inference when using Hermit - that's been a huge boon in my workflow.

// Fast object-unsat check
logger.info(
"Object-property precomputation is supported; using that to find unsatisfiable object properties...");
Expand Down
Loading