-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the Ember config by a React config #9
Conversation
Do we want to deploy the |
I don't think there is any harm in uploading it for the live version too. They are only loaded when having the developer tools open, so no impact for normal users, but significantly improves debuggability if we need to debug the live version. Besides, the code is open source, so it's not like the sourcemaps reveal anything new. Only impact is the harddrive space needed, which we should have plenty of. |
I think we should make some changes to the frontend to make it easier to inject config options during build (especially the backend host address). We're currently using the file |
Isn't it possible to just set an environment variable during building? Then you wouldn't need to change the |
Done with 56e3e57. I deployed the current frontend to https://staging.ontohub.org, but it indefinitely sends |
This happens because the backend responded with an error:
Updating the backend on staging fixed this. |
Can you open an issue in the frontend repo for this? Infinite loops should not happen... |
Done with ontohub/ontohub-frontend#94 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This allows us to deploy the react frontend. The ontohub-frontend repository is cloned to the local machine, the correct branch is checked out there and then it's built locally. We don't have any dependencies on the server for the frontend.
Unfortunately, we need to override some of the git tasks for this, but it's for a good cause.