This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
23 allow passing a lambda as record #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 25, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Na...
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Style/AsciiIdentifiers has the wrong namespace - should be Naming .rubocop.yml: Style/ClassAndModuleCamelCase has the wrong namespace - should be Naming .rubocop.yml: Style/ConstantName has the wrong namespace - should be Naming .rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/MethodName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/VariableName has the wrong namespace - should be Naming .rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. (obsolete configuration found in .rubocop.yml, please update it) The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`. obsolete parameter EnforcedStyle (for Style/Encoding) found in .rubocop.yml Style/Encoding no longer supports styles. The "never" behavior is always assumed. obsolete parameter SupportedStyles (for Style/Encoding) found in .rubocop.yml obsolete parameter AutoCorrectEncodingComment (for Style/Encoding) found in .rubocop.yml
houndci-bot
reviewed
Oct 25, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Na...
.rubocop.yml: Style/AccessorMethodName has the wrong namespace - should be Naming .rubocop.yml: Style/AsciiIdentifiers has the wrong namespace - should be Naming .rubocop.yml: Style/ClassAndModuleCamelCase has the wrong namespace - should be Naming .rubocop.yml: Style/ConstantName has the wrong namespace - should be Naming .rubocop.yml: Style/FileName has the wrong namespace - should be Naming .rubocop.yml: Style/MethodName has the wrong namespace - should be Naming .rubocop.yml: Style/PredicateName has the wrong namespace - should be Naming .rubocop.yml: Style/VariableName has the wrong namespace - should be Naming .rubocop.yml: Style/VariableNumber has the wrong namespace - should be Naming Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. (obsolete configuration found in .rubocop.yml, please update it) The `Style/OpMethod` cop has been renamed and moved to `Naming/BinaryOperatorParameterName`. obsolete parameter EnforcedStyle (for Style/Encoding) found in .rubocop.yml Style/Encoding no longer supports styles. The "never" behavior is always assumed. obsolete parameter SupportedStyles (for Style/Encoding) found in .rubocop.yml obsolete parameter AutoCorrectEncodingComment (for Style/Encoding) found in .rubocop.yml
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 6 6
Lines 267 295 +28
=====================================
+ Hits 267 295 +28
Continue to review full report at Codecov.
|
phyrog
force-pushed
the
23-allow_passing_a_lambda_as_record
branch
from
25cad1d to
cec4088
Compare
eugenk
reviewed
Oct 25, 2017
| def resolve_proc(current_user, old_resolve, options) | ||
| # rubocop:enable Metrics/MethodLength, Metrics/AbcSize |
There was a problem hiding this comment.
It's the last method in the file and re-enabling all disabled cops would add a lot of clutter. I'm planning on refactoring this file after this PR.
eugenk
suggested changes
Oct 25, 2017
| @@ -1,6 +1,7 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require 'spec_helper' | |||
| require 'pry' | |||
There was a problem hiding this comment.
Seems to be a leftover from debugging.
phyrog
force-pushed
the
23-allow_passing_a_lambda_as_record
branch
from
3ac7bfd to
a380c03
Compare
eugenk
approved these changes
Oct 26, 2017
There was a problem hiding this comment.
Gif doesn't work: https://media.giphy.com/media/xUNda7JWnhohQFU4Xm/giphy.gif
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23.