Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Refactoring #26

Merged
merged 3 commits into from
Oct 27, 2017
Merged

Refactoring #26

merged 3 commits into from
Oct 27, 2017

Conversation

phyrog
Copy link
Collaborator

@phyrog phyrog commented Oct 27, 2017

Refactors the instrumenters and the helpers to remove the rubocop exceptions.

@codecov-io
Copy link

codecov-io commented Oct 27, 2017

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           6      6           
  Lines         295    315   +20     
=====================================
+ Hits          295    315   +20
Impacted Files Coverage Δ
lib/graphql-pundit/instrumenters/authorization.rb 100% <100%> (ø) ⬆️
lib/graphql-pundit/instrumenters/scope.rb 100% <100%> (ø) ⬆️
lib/graphql-pundit.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b62c6c1...b71489a. Read the comment docs.

@phyrog phyrog changed the title Refactor the authorization instrumenter Refactoring Oct 27, 2017
Copy link
Member

@eugenk eugenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phyrog phyrog merged commit 3584d57 into master Oct 27, 2017
@phyrog phyrog deleted the refactor_authorization_instrumenter branch October 27, 2017 09:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants