-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Migrate the docs to the just-the-docs template #4
Conversation
Looks good to me. Same docs that @graybeal did earlier but searchable and with a menu on the left. Awesome, exactly what was missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend including a FAQ section for listing bug-fixing for commonly known issues for quick reference. e.g., the number of visits not being updated, the ontology page taking a long time to show the list of ontologies, the group cannot be updated for an ontology, etc. Over time, this FAQ section may become a troubleshooting guide and even a guided search may be built on top in the distant future.
@arsarkar OK. thanks for suggestion. Can you transform this into a feature request on the issues section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to me.
This comment was marked as duplicate.
This comment was marked as duplicate.
It looks good Syphax! Will the section about documentation configuration be visible to all who visit the page? If so, do you think this might be confusing to them? |
Hi @xeniacs, thanks for your feedback. Yeah it will be visible and certainly it is confusing for visitors. I will surely remove/hide it in the future, but for now this PR is just about the technology behind the scene. After I will let you @xeniacs , @jonquet , @graybeal, ... take the responsibilities of the editorial part (see discussion ontoportal/ontoportal-project#1) And also can you please "approve this PR" if you agree with the change. |
There is a troubleshooting page (or two) and that/they may be repurposed into what you suggest. I think organizing them thematically may help people zero in on what they need.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caveats: I'm not capable of reviewing changes on 191 files, and I'm not technically proficient enough to understand what I'm looking at in this pull request. (Would be happy to have someone take the hour or three it would take to teach me....)
Nonetheless, I am approving the change, because (A) it adds an important feature, (B) any issues can be addressed in subsequent work if it is important, and (C) I trust Syphax's judgment about whether this is "better".
It is not clear to me that when the pull request is approved, the existing location of the docs https://ontoportal.github.io/administration/ will be serving this new material. I assume it will, but I think this is necessary because everything points to that location.
Hi @graybeal , thanks for the approvement.
It's not really important to understand the technical behind, in this pull request you only need to check if it respond to our requirements for a centralized documentation for the alliance. But yeah I have no problem "to take the hour or three hour" to explain it if needed, Although what it is really important to document (in my opninoin) , is a "how to contribute to the documentation" page
In summary: "Yes" In details:
Yes, it will be the same, but we will have an editorial problem after. That are:
In summary, the next actions after the merge (that I would propose) are:
|
head to read this twice, but I think I got it with a few clarifications:
There is a page that describes in detail how to work with the documentation (I'm sure you are aware of that). But several caveats about that existing page:
Also, none of the 3 or so internal links that I've tested have worked. It may have to do with the way I used absolute or relative links, which IIRC were a little weird in the previous technology. |
I think that there is no need to create a new repo, just changing the current one name would be enaugh
I updated the bultes 👍
Yes, this one: https://github.com/ontoportal/administration/blob/master/docs/README.md, we just need to update it (some infos will be depreacted, e.g there is no need of collections configuration) . I think also we need to make less a detailed configuration documentation and more a guided tutorial of how to add/edit a page on the documentation. (it's just a proposition, but yes it is the subject of another discussion)
Fixed ontoportal-lirmm@7e204c1 |
…-if-page-not-existent Feature: Hide doc nav icon if page not existent
Context
From our discussions
I extracted this action item " being able to search in the doc ", but to do that I needed to use a template (theme) that implement it. I did choose https://just-the-docs.github.io/just-the-docs/
Preview
See https://ontoportal-lirmm.github.io/documentation/administration
I migrated all the existent content and kept the same configuration data (status, description, order,....)
What's new