Skip to content

Commit

Permalink
Auto merge of rust-lang#116381 - Mark-Simulacrum:drop-wasm32-unknown-…
Browse files Browse the repository at this point in the history
…emscripten, r=Kobzol

Remove wasm32-unknown-emscripten tests from CI

This builder tested the wasm32-unknown-emscripten target, which is tier 2 (and so not eligible for testing). In the recent beta [promotion](rust-lang#116362 (comment)), we ran into a problem with this target: emscripten doesn't support passing environment variables into the std environment, so we can't enable RUSTC_BOOTSTRAP for libtest in order to pass -Zunstable-options.

We worked around this for the beta/stable branches, but given this problem, and its tier 2 status, just dropping the target's tests entirely seems warranted. Downgrading to tier 3 may also be a good idea, but that is a separate conversation not proposed here.
  • Loading branch information
bors committed Oct 4, 2023
2 parents 65519f5 + c0a42cc commit 2ffeb46
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 69 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -266,9 +266,6 @@ jobs:
- name: test-various
os: ubuntu-20.04-8core-32gb
env: {}
- name: wasm32
os: ubuntu-20.04-8core-32gb
env: {}
- name: x86_64-gnu
os: ubuntu-20.04-4core-16gb
env: {}
Expand Down
63 changes: 0 additions & 63 deletions src/ci/docker/host-x86_64/wasm32/Dockerfile

This file was deleted.

3 changes: 0 additions & 3 deletions src/ci/github-actions/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -429,9 +429,6 @@ jobs:
- name: test-various
<<: *job-linux-8c

- name: wasm32
<<: *job-linux-8c

- name: x86_64-gnu
<<: *job-linux-4c

Expand Down

0 comments on commit 2ffeb46

Please sign in to comment.