Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added frontend logical polish #2274

Merged
merged 5 commits into from
Aug 30, 2024
Merged

Added frontend logical polish #2274

merged 5 commits into from
Aug 30, 2024

Conversation

hagen-danswer
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 11:06pm

@@ -125,14 +125,12 @@ export const DocumentSetCreationForm = ({
placeholder="Describe what the document set represents"
autoCompleteDisabled={true}
/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should show the element regardless of situation

@@ -76,30 +78,27 @@ export const IsPublicGroupSelector = <T extends IsPublicGroupSelectorFormType>({
disabled={!isAdmin}
subtext={
<span className="block mt-2 text-sm text-gray-500">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reworded string to make it more clear

If set, then this {objectName} will be usable by{" "}
<b>All {publicToWhom}</b>. Otherwise, only <b>{publicToWhom}</b>{" "}
who have explicitly been given access to this {objectName} (e.g.
via a User Group) and <b>All Admins</b> will have access.
</span>
}
/>
</>
)}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not show group selector if there are no groups

@@ -16,6 +16,33 @@ import {
} from "./icons/icons";
import { pageType } from "@/app/chat/sessionSidebar/types";

interface DropdownOptionProps {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turned the dropdown options into a component

icon={<LightSettingsIcon className="h-5 w-5 my-auto mr-2" />}
label="Curator Panel"
/>
)
)}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed logical issue that would cause the border to show when only logout was present

also allows admins/curators to logout from admin/curator menu

@yuhongsun96
Copy link
Contributor

Make Documents Public
If set, then documents indexed by this connector will be visible to all users. If turned off, then only users who explicitly have been given access to the documents (e.g. through a User Group) will have access

Curator Accessible
If set, this Credential will be useable by all Curators. If turned off, only Admins or specific Curators (who been explicitly granted access via User Groups) can use this Credential.

@yuhongsun96 yuhongsun96 disabled auto-merge August 30, 2024 23:42
@yuhongsun96 yuhongsun96 merged commit 355326f into main Aug 30, 2024
6 of 7 checks passed
@yuhongsun96 yuhongsun96 deleted the is-public-string branch August 30, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants