-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added frontend logical polish #2274
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -125,14 +125,12 @@ export const DocumentSetCreationForm = ({ | |||
placeholder="Describe what the document set represents" | |||
autoCompleteDisabled={true} | |||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should show the element regardless of situation
@@ -76,30 +78,27 @@ export const IsPublicGroupSelector = <T extends IsPublicGroupSelectorFormType>({ | |||
disabled={!isAdmin} | |||
subtext={ | |||
<span className="block mt-2 text-sm text-gray-500"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reworded string to make it more clear
If set, then this {objectName} will be usable by{" "} | ||
<b>All {publicToWhom}</b>. Otherwise, only <b>{publicToWhom}</b>{" "} | ||
who have explicitly been given access to this {objectName} (e.g. | ||
via a User Group) and <b>All Admins</b> will have access. | ||
</span> | ||
} | ||
/> | ||
</> | ||
)} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not show group selector if there are no groups
@@ -16,6 +16,33 @@ import { | |||
} from "./icons/icons"; | |||
import { pageType } from "@/app/chat/sessionSidebar/types"; | |||
|
|||
interface DropdownOptionProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
turned the dropdown options into a component
icon={<LightSettingsIcon className="h-5 w-5 my-auto mr-2" />} | ||
label="Curator Panel" | ||
/> | ||
) | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed logical issue that would cause the border to show when only logout was present
also allows admins/curators to logout from admin/curator menu
Make Documents Public Curator Accessible |
No description provided.