Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #2298

Merged
merged 5 commits into from
Sep 2, 2024
Merged

Update CONTRIBUTING.md #2298

merged 5 commits into from
Sep 2, 2024

Conversation

rkuo-danswer
Copy link
Contributor

@rkuo-danswer rkuo-danswer commented Sep 2, 2024

Description

update contributing docs.

Also a requirements upgrade to filelock ... pinning the version previously at 3.12.0 is a direct conflict with virtualenv requirements.

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 9:47pm

@yuhongsun96 yuhongsun96 added this pull request to the merge queue Sep 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2024
@yuhongsun96 yuhongsun96 added this pull request to the merge queue Sep 2, 2024
@yuhongsun96 yuhongsun96 removed this pull request from the merge queue due to a manual request Sep 2, 2024
@yuhongsun96 yuhongsun96 merged commit abe0114 into main Sep 2, 2024
7 checks passed
@yuhongsun96 yuhongsun96 deleted the bugfix/contributing_updates branch September 2, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants