Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user dropdown seed-able list #2308

Merged
merged 7 commits into from
Sep 3, 2024
Merged

Add user dropdown seed-able list #2308

merged 7 commits into from
Sep 3, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Sep 3, 2024

Description

Allow people to configure user dropdown custom links / icons / titles

A couple of perfectly valid possible approaches (for the icon side specifically)

  • User uploads image during seeding -> render image
  • User specifies name from predefined list -> render from map
  • (went with this one) User specific name from FaIcon/react https://fontawesome.com/icons/react and we dynamically load, cache, and render the specific icon

Sample environment variable: ENV_SEED_CONFIGURATION='{"enterprise_settings": {"custom_nav_items": [{"title": "Documentation", "link": "https://docs.example.com", "icon": "Book"}, {"title": "Support", "link": "https://support.example.com", "icon": "phone"}]}}'

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 6:54pm

Copy link
Contributor

@Weves Weves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an image of what this looks like? 👀

backend/ee/danswer/server/enterprise_settings/models.py Outdated Show resolved Hide resolved
@pablonyx
Copy link
Contributor Author

pablonyx commented Sep 3, 2024

Is there an image of what this looks like? 👀

Screenshot 2024-09-03 at 11 51 39 AM

@Weves Weves added this pull request to the merge queue Sep 3, 2024
Merged via the queue into main with commit 32359d2 Sep 3, 2024
7 checks passed
@pablonyx pablonyx deleted the custom_settings_dropdown branch October 17, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants