Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAN-554 fixing a race condition in celery task wrapper. could randomly blow u… #2321

Merged
merged 1 commit into from
Sep 4, 2024
Merged

DAN-554 fixing a race condition in celery task wrapper. could randomly blow u… #2321

merged 1 commit into from
Sep 4, 2024
+11 −5

Conversation

rkuo-danswer
Copy link
Contributor

…p any task.

Fixes DAN-554.

Description

[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

@vercel Vercel
Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 3:09am

@rkuo-danswer rkuo-danswer marked this pull request as ready for review September 4, 2024 03:29
@yuhongsun96 yuhongsun96 changed the title fixing a race condition in celery task wrapper. could randomly blow u… DAN-554 fixing a race condition in celery task wrapper. could randomly blow u… Sep 4, 2024
yuhongsun96
yuhongsun96 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@yuhongsun96 yuhongsun96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yuhongsun96 yuhongsun96 added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 630e224 Sep 4, 2024
7 checks passed
@rkuo-danswer rkuo-danswer deleted the bugfix/task_wrappers branch September 4, 2024 05:16
@onimsha onimsha mentioned this pull request Sep 13, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhongsun96 yuhongsun96 yuhongsun96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkuo-danswer @yuhongsun96