Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use user information in Slack bot DMs #2360

Merged
merged 2 commits into from
Sep 8, 2024
Merged

Use user information in Slack bot DMs #2360

merged 2 commits into from
Sep 8, 2024

Conversation

hj-danswer
Copy link
Contributor

@hj-danswer hj-danswer commented Sep 8, 2024 •
edited
Loading

Description

When user interacts with DanswerBot in Slack DM, we want to use the user's information such that the user gets information about their private files. We use the email address tied to the Slack event to get user information and use it in the get_search_answer request.

How Has This Been Tested?

  • Add private connector for a file.
  • Danswerbot cannot answer question about the file in public channel.
  • Danswerbot can answer question about the file in DM.

Accepted Risk

[Any know risks or failure modes to point out to reviewers]
Added requests to Slack and database.

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

@vercel Vercel
Copy link

vercel bot commented Sep 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2024 1:25am

@hj-danswer
Copy link
Contributor Author

Screenshot 2024-09-07 at 6 44 25 PM Screenshot 2024-09-07 at 6 44 44 PM

@hj-danswer hj-danswer changed the title Use user information from Slack bot DMs Use user information in Slack bot DMs Sep 8, 2024
yuhongsun96
yuhongsun96 approved these changes Sep 8, 2024
View reviewed changes
Copy link
Contributor

@yuhongsun96 yuhongsun96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hj-danswer hj-danswer added this pull request to the merge queue Sep 8, 2024
Merged via the queue into main with commit b43e573 Sep 8, 2024
7 checks passed
@onimsha onimsha mentioned this pull request Sep 13, 2024
Merged
8 tasks
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
@hj-danswer
Use user information in Slack bot DMs (onyx-dot-app#2360)
2648754 
* Use user information from Slack bot DMs

* fix lint

---------

Co-authored-by: Hyeong Joon Suh <hyeongjoonsuh@Hyeongs-MacBook-Pro.local>
rajivml pushed a commit to UiPath/danswer that referenced this pull request Oct 2, 2024
@hj-danswer
Use user information in Slack bot DMs (onyx-dot-app#2360)
7307ad0 
* Use user information from Slack bot DMs

* fix lint

---------

Co-authored-by: Hyeong Joon Suh <hyeongjoonsuh@Hyeongs-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhongsun96 yuhongsun96 yuhongsun96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hj-danswer @yuhongsun96