Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harden connections to redis #2677

Merged
merged 9 commits into from
Oct 4, 2024
Merged

harden connections to redis #2677

merged 9 commits into from
Oct 4, 2024

Conversation

rkuo-danswer
Copy link
Contributor

Description

Fixes DAN-764.
Sets several retry and keepalive mechanisms across our own redis pools and celery's connections to redis.

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 0:31am

@rkuo-danswer rkuo-danswer marked this pull request as ready for review October 4, 2024 00:53
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR focuses on improving Redis connection handling and Celery configurations in the Danswer application, aiming to enhance reliability and stability, particularly in production environments.

  • Introduced new Redis health check and connection pool configurations in app_configs.py
  • Added Redis socket keepalive options in constants.py to maintain persistent connections
  • Enhanced redis_pool.py with configurable health checks and keepalive settings for Redis connections
  • Updated Celery configuration in celeryconfig.py with retry mechanisms and improved Redis connection handling
  • Added CELERY_BROKER_POOL_LIMIT environment variable to Docker Compose files for better Redis connection management

6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@Weves Weves added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 3755e57 Oct 4, 2024
7 checks passed
@rkuo-danswer rkuo-danswer deleted the feature/redis_pools branch October 23, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants