-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
harden connections to redis #2677
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…keepalive_options where possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR focuses on improving Redis connection handling and Celery configurations in the Danswer application, aiming to enhance reliability and stability, particularly in production environments.
- Introduced new Redis health check and connection pool configurations in
app_configs.py
- Added Redis socket keepalive options in
constants.py
to maintain persistent connections - Enhanced
redis_pool.py
with configurable health checks and keepalive settings for Redis connections - Updated Celery configuration in
celeryconfig.py
with retry mechanisms and improved Redis connection handling - Added
CELERY_BROKER_POOL_LIMIT
environment variable to Docker Compose files for better Redis connection management
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Description
Fixes DAN-764.
Sets several retry and keepalive mechanisms across our own redis pools and celery's connections to redis.
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk
[Any know risks or failure modes to point out to reviewers]
Related Issue(s)
[If applicable, link to the issue(s) this PR addresses]
Checklist: