disable another flaky assert #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hagen-danswer
approved these changes
Oct 4, 2024
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses a flaky test in the knowledge chat functionality by disabling an assertion in the test_all_stream_chat_message_objects_outputs function.
- Commented out assertion for top document ID in third question response in
/backend/tests/integration/tests/dev_apis/test_knowledge_chat.py - Change aims to resolve issue DAN-765 related to inconsistent test results
- Flakiness likely caused by non-deterministic query rephrasing in the LLM
- Modification improves test stability without compromising core functionality validation
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+186
to
+188
| # flakiness likely due to non-deterministic rephrasing | ||
| # FLAKY - check that the top documents are correct | ||
| # assert response_json["top_documents"][0]["document_id"] == cc_pair_1.documents[2].id |
There was a problem hiding this comment.
logic: Commenting out this assertion may hide potential issues with document retrieval or ranking. Consider adding alternative checks or logging to monitor the behavior.
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes DAN-765. flaky knowledge chat test.
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk
[Any know risks or failure modes to point out to reviewers]
Related Issue(s)
[If applicable, link to the issue(s) this PR addresses]
Checklist: