Jira and Confluence connector features #2682
Conversation
Jira: - Add include_custom_fields feature to the UI and BE also (now you checkbox custom jira columns will be indexing and put to metadata) - Add skip_labels to the UI while creating connector Confluence: - Fix skip_labels for confluence attachments - Add this option to the UI
|
@useruid is attempting to deploy a commit to the Danswer Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the Jira and Confluence connectors with new features and fixes:
- Added support for indexing Jira custom fields, improving search and answer quality
- Implemented skip_labels functionality for both Jira and Confluence connectors
- Fixed skip_labels for Confluence attachments to exclude specific attachments
- Updated frontend configuration to include new options for custom fields and skip_labels
- Tested with Jira and Confluence server versions, but cloud version testing is still pending
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
| # pages. | ||
| labels_to_skip: list[str] = CONFLUENCE_CONNECTOR_LABELS_TO_SKIP, | ||
| # pages. Added default None to backward compatibility | ||
| labels_to_skip: list[str] = None or CONFLUENCE_CONNECTOR_LABELS_TO_SKIP, |
There was a problem hiding this comment.
style: Consider using a default argument that doesn't rely on short-circuit evaluation
| if labels_to_skip: | ||
| attachment_labels = [ | ||
| label["name"] for label in attachment["metadata"]["labels"]["results"] | ||
| ] | ||
| label_intersection = labels_to_skip.intersection(attachment_labels) | ||
| if label_intersection and attachment_labels: | ||
| return None |
There was a problem hiding this comment.
style: This block could be moved to a separate method for better readability
| @@ -106,6 +107,7 @@ def fetch_jira_issues_batch( | |||
| batch_size: int = INDEX_BATCH_SIZE, | |||
| comment_email_blacklist: tuple[str, ...] = (), | |||
| labels_to_skip: set[str] | None = None, | |||
| custom_fields: dict | None = None, | |||
There was a problem hiding this comment.
style: Consider adding type hints for the custom_fields parameter
|
We are covering the confluence functionality with this pr here: For the jira functionality, we are being very careful about the metadata we use to enhance our search. Right now we are in the middle of looking into what that would look like for Jira specifically, but we will certainly consider using custom fields. Keep an eye out for that change sometime soon! |
Description
Jira:
Confluence:
How Has This Been Tested?
Tested with Jira and Confluence server. Custom fields are now indexed and exists in metadata. This improves search and answer quality. For Confluence I tried different labels to attachments, now everything is correct.
Accepted Risk
To test it with cloud version.
Related Issue(s)
[If applicable, link to the issue(s) this PR addresses]
Checklist: