Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check before using fetch_versioned_implementation because it logs war… #2708

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

rkuo-danswer
Copy link
Contributor

…nings that confuse users.

Renamed get_is_ee_version to is_ee_version to be less redundant

Description

Fixes DAN-776.

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

…nings that confuse users.

Renamed get_is_ee_version to is_ee_version to be less redundant
Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 7:36pm

…fix/quiet-versioned-warnings

# Conflicts:
#	backend/danswer/background/celery/tasks/vespa/tasks.py
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request focuses on improving code clarity and reducing unnecessary warnings in the Danswer project. Here's a concise summary of the key changes:

  • Renamed get_is_ee_version to is_ee_version in DanswerVersion class for clarity
  • Added enterprise edition checks before executing certain functionality in Vespa sync tasks and Redis operations
  • Updated usage of the renamed method throughout the codebase
  • Implemented changes primarily in backend/danswer/utils/variable_functionality.py
  • Modified celery_redis.py to prevent unnecessary warnings in non-enterprise editions
  • Updated tasks/vespa/tasks.py to avoid exceptions in the MIT version for user group sync tasks

These changes aim to enhance user experience by reducing confusing warnings and improving code readability.

5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@pablonyx pablonyx added this pull request to the merge queue Oct 7, 2024
@pablonyx pablonyx removed this pull request from the merge queue due to a manual request Oct 7, 2024
@pablonyx pablonyx added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 1a3469d Oct 7, 2024
7 of 12 checks passed
@rkuo-danswer rkuo-danswer deleted the bugfix/quiet-versioned-warnings branch October 7, 2024 22:23
@rkuo-danswer rkuo-danswer restored the bugfix/quiet-versioned-warnings branch October 7, 2024 22:23
@rkuo-danswer rkuo-danswer deleted the bugfix/quiet-versioned-warnings branch October 7, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants