Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better logging for actions being taken inside document_by_cc_pair_cle… #2713

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

rkuo-danswer
Copy link
Contributor

…anup

Description

Fixes DAN-780. Logs will now look like

        task_logger.info(
            f"document_id={document_id} refcount={count} action={action} chunks={chunks_affected}"
        )

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 8:55pm

@rkuo-danswer rkuo-danswer marked this pull request as ready for review October 7, 2024 21:57
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request enhances logging and return values for document cleanup and indexing operations in the Danswer system.

  • Improved logging in document_by_cc_pair_cleanup_task now includes document ID, reference count, action taken, and affected chunks
  • Modified VespaIndex.update_single and delete_single methods to return the number of chunks affected
  • Updated DocumentIndex interface to reflect new return types for update_single and delete_single
  • Enhanced error handling and logging in VespaIndex class for better visibility into indexing operations

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@pablonyx pablonyx added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 79d3715 Oct 7, 2024
7 checks passed
@rkuo-danswer rkuo-danswer deleted the bugfix/cleanup_task_logging branch October 7, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants