Temp patch to remove multiple tool calls #2720
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Removed the tools parameter from the _process_llm_stream method call in the _raw_output_for_explicit_tool_calling_llms method of the Answer class, addressing the current limitation of not supporting multiple tool calls in sequence.
- Modified
_raw_output_for_explicit_tool_calling_llmsinbackend/danswer/llm/answering/answer.pyto removetoolsparameter from_process_llm_streamcall - Added a comment explaining the reason for removal: multiple tool calls in sequence are not currently supported
- This change simplifies the tool calling process but may limit functionality for scenarios requiring multiple sequential tool calls
- Potential impact on future extensibility if multiple tool calls become necessary
- Consider adding a TODO or issue to track the potential need for supporting multiple tool calls in the future
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+319
to
+321
| # as of now, we don't support multiple tool calls in sequence, which is why | ||
| # we don't need to pass this in here | ||
| # tools=[tool.tool_definition() for tool in self.tools], |
There was a problem hiding this comment.
logic: Removing tools parameter may prevent future tool calls. Consider implications for extensibility.
pablonyx
approved these changes
Oct 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Weves
added a commit
that referenced
this pull request
Oct 8, 2024
Weves
added a commit
that referenced
this pull request
Oct 8, 2024
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
^