Multi tenant vespa #2762
Merged
Multi tenant vespa #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces multi-tenant support for Vespa indexing and search functionality across the Danswer application. Key changes include:
- Added
setup_multitenant_danswer()andsetup_vespa_multitenant()functions in/backend/danswer/setup.pyfor multi-tenant Vespa index setup - Introduced
tenant_idfield in/backend/danswer/document_index/vespa/app_config/schemas/danswer_chunk.sdfor Vespa schema - Modified
VespaIndexclass in/backend/danswer/document_index/vespa/index.pyto support multi-tenant indexing and improved document deletion - Added
SupportedEmbeddingModelclass in/backend/shared_configs/model_server_models.pyfor managing multiple embedding models - Updated search preprocessing in
/backend/danswer/search/preprocessing/preprocessing.pyto include tenant-specific filtering
15 file(s) reviewed, 24 comment(s)
Edit PR Review Bot Settings | Greptile
* k * data -> control * nit * nit: error handling * auth + app * nit: color standardization * nit * nit: typing * k * k * feat: functional upgrading * feat: add block for downgrading to seats < active users * add auth * remove accomplished todo + prints * nit * tiny nit * nit: centralize security * add tenant expulsion/gating + invite user -> increment billing seat no. * add cloud configs * k * k * nit: update
pablonyx
force-pushed
the
multi_tenant_vespa
branch
from
895adc4 to
a01daed
Compare
yuhongsun96
approved these changes
Oct 12, 2024
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes in this PR]
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk
[Any know risks or failure modes to point out to reviewers]
Related Issue(s)
[If applicable, link to the issue(s) this PR addresses]
Checklist: