Confluence permission sync fix for server deployment #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed Confluence permission synchronization for local server deployment, focusing on improved handling of server and cloud instances.
- Introduced caching for user emails in
_USER_EMAIL_CACHEto reduce API calls - Added separate functions
_get_server_space_permissionsand_get_cloud_space_permissionsfor different Confluence deployments - Improved space permissions handling in
_get_space_permissionsto support both server and cloud instances - TODO: Implement public access checking for spaces, currently assumed not public
- Warning: Potential limitation in
_extract_read_access_restrictionsfor pages with over 200 users or groups
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
hagen-danswer
changed the title
Weves
approved these changes
Oct 14, 2024
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is still room for improvement here