fix index attempt refreshing automatically #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request implements automatic refreshing of index attempts data in the connector management interface, enhancing real-time updates for users.
- Added periodic data fetching every 5 seconds in
web/src/app/admin/connector/[ccPairId]/IndexingAttemptsTable.tsx - Updated
useEffectdependency array inweb/src/app/admin/connector/[ccPairId]/page.tsxto includefinishConnectorDeletion - Potential performance impact due to frequent API calls in
IndexingAttemptsTable.tsx - Improved handling of connector deletion process in
page.tsx
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -145,7 +145,7 @@ export function IndexingAttemptsTable({ ccPair }: { ccPair: CCPairFullInfo }) { | |||
| if (!cachedBatches[0]) { | |||
| fetchBatchData(0); | |||
| } | |||
| }, [ccPair.id, page, cachedBatches, totalPages]); | |||
| }, [ccPair.id, page, cachedBatches, totalPages, fetchBatchData]); | |||
There was a problem hiding this comment.
style: Adding fetchBatchData to the dependency array may cause unnecessary re-renders. Consider using useCallback for fetchBatchData
pablonyx
approved these changes
Oct 15, 2024
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes DAN-811.
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk
[Any know risks or failure modes to point out to reviewers]
Related Issue(s)
[If applicable, link to the issue(s) this PR addresses]
Checklist: