Notion Empty Property Fix

[yuhongsun96]

Description

Notion connector exception handling

How Has This Been Tested?

Issue not reproducible sadly, not sure why empty properties on our own pages don't result in this issue

Accepted Risk

N/A

Related Issue(s)

N/A

Checklist:

• All of the automated tests pass
• All PR comments are addressed and marked resolved
• If there are migrations, they have been rebased to latest main
• If there are new dependencies, they are added to the requirements
• If there are new environment variables, they are added to all of the deployment methods
• If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
• Docker images build and basic functionalities work
• Author has done a final read through of the PR right before merge

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
internal-search	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 16, 2024 4:52am

[greptile-apps]

PR Summary

This PR enhances the Notion connector's exception handling for empty properties, improving its robustness when dealing with potentially missing or empty data.

• Modified _properties_to_str method in backend/danswer/connectors/notion/connector.py to handle empty dictionaries and properties
• Updated _read_pages_from_database method to include additional checks for empty data
• Improved error handling in the Notion connector to prevent exceptions caused by empty properties
• Changes focus on maintaining connector stability when encountering unexpected data structures from Notion API

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}