Notion Recurse Empty Final Field

[yuhongsun96]

Description

In Notion pages nested in databases, sometimes a property field can be null leading to a NoneType instead of a final value to be extracted

How Has This Been Tested?

Issue has been replicated and patched

Accepted Risk

N/A

Related Issue(s)

N/A

Checklist:

• All of the automated tests pass
• All PR comments are addressed and marked resolved
• If there are migrations, they have been rebased to latest main
• If there are new dependencies, they are added to the requirements
• If there are new environment variables, they are added to all of the deployment methods
• If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
• Docker images build and basic functionalities work
• Author has done a final read through of the PR right before merge

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
internal-search	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 16, 2024 6:03am

[greptile-apps]

PR Summary

This pull request modifies the NotionConnector class to improve handling of NoneType values in Notion properties, particularly for pages nested in databases.

• Updated _properties_to_str method in backend/danswer/connectors/notion/connector.py to return None for empty properties instead of 'N/A'
• Enhanced handling of list properties to prevent potential errors with null values
• Improved error handling for unreadable properties to maintain data integrity
• These changes aim to prevent crashes and ensure more accurate data extraction from Notion pages with varying property structures

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}