Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use native rate limiting in the confluence client #2837

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

rkuo-danswer
Copy link
Contributor

Description

Fixes DAN-833. Uses confluence's native rate limiter with some of our own. This allows rate limiting to be applied within individual rest client api calls that might internally make multiple rest calls.

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 5:32pm

@rkuo-danswer rkuo-danswer marked this pull request as ready for review October 17, 2024 21:29
…ture/confluence-native-rate-limit

# Conflicts:
#	backend/requirements/default.txt
Copy link
Contributor

@hagen-danswer hagen-danswer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hagen-danswer hagen-danswer added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 5b78299 Oct 18, 2024
7 checks passed
@hagen-danswer hagen-danswer deleted the feature/confluence-native-rate-limit branch October 18, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants