Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

working chat feedback dump script (with api addition) #2891

Merged
merged 5 commits into from
Oct 24, 2024
Merged

working chat feedback dump script (with api addition) #2891

merged 5 commits into from
Oct 24, 2024

Conversation

rkuo-danswer
Copy link
Contributor

Description

Fixes DAN-861.

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 6:47pm

@rkuo-danswer rkuo-danswer marked this pull request as ready for review October 24, 2024 00:11
pablonyx
pablonyx approved these changes Oct 24, 2024
View reviewed changes
backend/ee/danswer/server/query_history/api.py Show resolved Hide resolved
backend/scripts/chat_feedback_dump.py Outdated Show resolved Hide resolved
backend/scripts/chat_feedback_dump.py Show resolved Hide resolved
@rkuo-danswer rkuo-danswer added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 2b9a751 Oct 24, 2024
7 checks passed
@rkuo-danswer rkuo-danswer deleted the feature/chat_feedback_dump branch October 24, 2024 22:01
This was referenced Nov 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablonyx pablonyx pablonyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkuo-danswer @pablonyx