-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-enable helm #3053
re-enable helm #3053
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are the ways we tested this? Does this work locally on minikube and on EKS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh also, one other quick question. Since Vespa is a container and we've done it as a chart, why do we not do it for our backend container and web container?
It's a thought and might help more advanced deployments with deploying different parts of the app. |
* re-enable helm * allow manual triggering * change vespa host * change vespa chart location * update Chart.lock * update ct.yaml with new vespa chart repo * bump vespa to 0.2.5 * update Chart.lock * update to vespa 0.2.6 * bump vespa to 0.2.7 * bump to 0.2.8 * bump version * try appending the ordinal * try new configmap * bump vespa * bump vespa * add debug to see if we can figure out what ct install thinks is failing * add debug flag to helm * try disabling nginx because of KinD * use helm-extra-set-args * try command line * try pointing test connection to the correct service name * bump vespa to 0.2.12 * update chart.lock * bump vespa to 0.2.13 * bump vespa to 0.2.14 * bump vespa * bump vespa * re-enable chart testing only on changes * name the check more specifically than "lint-test" * add some debugging * try setting remote * might have to specify chart dirs directly * add comments --------- Co-authored-by: Richard Kuo <rkuo@rkuo.com>
Description
Fixes DAN-953.
Fixes DAN-954.
Fixes DAN-563.
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Accepted Risk (provide if relevant)
N/A
Related Issue(s) (provide if relevant)
N/A
Mental Checklist:
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.