Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable helm #3053

Merged
merged 34 commits into from
Nov 10, 2024
Merged

re-enable helm #3053

merged 34 commits into from
Nov 10, 2024

Conversation

rkuo-danswer
Copy link
Contributor

@rkuo-danswer rkuo-danswer commented Nov 5, 2024

Description

Fixes DAN-953.
Fixes DAN-954.
Fixes DAN-563.

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 2:25am

Copy link
Contributor

@yuhongsun96 yuhongsun96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the ways we tested this? Does this work locally on minikube and on EKS?

Copy link
Contributor

@yuhongsun96 yuhongsun96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh also, one other quick question. Since Vespa is a container and we've done it as a chart, why do we not do it for our backend container and web container?

@rkuo-danswer
Copy link
Contributor Author

@yuhongsun96

What are the ways we tested this? Does this work locally on minikube and on EKS?
Just tried it on EKS and it does work (although EKS has its own specific nits to work through ... but none requiring helm chart changes.). Works on kind as shown in the helm chart testing and minikube last I checked.

Oh also, one other quick question. Since Vespa is a container and we've done it as a chart, why do we not do it for our backend container and web container?

It's a thought and might help more advanced deployments with deploying different parts of the app.

@rkuo-danswer rkuo-danswer added this pull request to the merge queue Nov 10, 2024
Merged via the queue into main with commit 9d57f34 Nov 10, 2024
8 checks passed
@yuhongsun96 yuhongsun96 deleted the bugfix/helm_again branch November 10, 2024 18:51
pablonyx pushed a commit that referenced this pull request Nov 11, 2024
* re-enable helm

* allow manual triggering

* change vespa host

* change vespa chart location

* update Chart.lock

* update ct.yaml with new vespa chart repo

* bump vespa to 0.2.5

* update Chart.lock

* update to vespa 0.2.6

* bump vespa to 0.2.7

* bump to 0.2.8

* bump version

* try appending the ordinal

* try new configmap

* bump vespa

* bump vespa

* add debug to see if we can figure out what ct install thinks is failing

* add debug flag to helm

* try disabling nginx because of KinD

* use helm-extra-set-args

* try command line

* try pointing test connection to the correct service name

* bump vespa to 0.2.12

* update chart.lock

* bump vespa to 0.2.13

* bump vespa to 0.2.14

* bump vespa

* bump vespa

* re-enable chart testing only on changes

* name the check more specifically than "lint-test"

* add some debugging

* try setting remote

* might have to specify chart dirs directly

* add comments

---------

Co-authored-by: Richard Kuo <rkuo@rkuo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants