Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search dropdown #3269

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Fix search dropdown #3269

merged 4 commits into from
Nov 27, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Nov 27, 2024

Description

Fix search dropdown

Screen.Recording.2024-11-27.at.7.37.11.AM.mov

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Nov 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 3:50pm

@pablonyx pablonyx marked this pull request as ready for review November 27, 2024 15:47
@pablonyx pablonyx changed the title validate dropdown Fix search dropdown Nov 27, 2024
@hagen-danswer hagen-danswer added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 28e2b78 Nov 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants