Fix: Eliminate symres phase #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves a long-standing technical debt in the Onyx compiler. The compilation pipeline of each node is separated out into multiple stages (parsing, type-checking, code generation). In the early days of the compiler, there was not an "async" mechanism in the compiler to allow for nodes to wait on other nodes to finish checking. Because of this, compilation was split into 4 steps, adding symbol resolution before type-checking to allow for more flexible programs.
Once the async mechanism was introduced into the compiler, splitting symbol resolution from type checking was entirely unnecessary. However, since each of these steps was thousands of lines of code, merging them was going to be a difficult, bug-prone undertaking. I have finally decided to tackle this technical debt and simplified the compiler in the process.
This change is "just as correct" as the current compiler in the master branch. Every program that compiled with the old compiler still compiles.