First swipe to get tinyMCEs in #multiple fields #41
Conversation
| 'textarea_name' => $id, | ||
| 'textarea_rows' => count( $lines ), | ||
| ) ); | ||
| $results[$id] = ob_get_clean(); |
There was a problem hiding this comment.
I have no idea about the performance implications but do you think it would be better to call ob_start() once outside of the loop and then ob_get_contents() and ob_clean() in the loop?
There was a problem hiding this comment.
I did a little research and couldn't find anything about the performance impact of starting and ending output buffering multiple times – the only difference that i see is that the output is potentially contained in memory slightly longer, but I think that happens with the PHP-level output buffering that is on by default anyway, and so it would just be a merely syntactical change that i think would be more confusing than having the start/get/end piece within the loop.
|
so far so good! |
Need to put together a better test scenario for this (and the whole plugin in general!)
|
nudge, nudge 🐤 |
|
BUMP! I need this for CRE plzzzzz @bendoh |
|
I know but it's not easy and I'm not exactly swimming in free time here! |
|
Kk that's fine - I'm just going to add a couple extra MCE fields that they can use instead of letting them have an arbitrary number. |
|
FYI... I did this exact thing back in my WPMU Dev days. Want me to see if I can dig that code up? |
Summary
Addresses issue #38 – Allow for
#multiplefields to containmce-type fields, which involves some JavaScript hoop-jumping-through.Relavant Ticket(s)
Issue #38