-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use biome for JS linting #133
base: main
Are you sure you want to change the base?
Conversation
@syzygy333 - I ran into errors when testing. I'm on an M1 Mac, so I occasionally see these arm64 version errors with packages. When running
I needed to install biome from scratch or delete the lock file to get the right architecture support:
This seems to track with this known issue: npm/cli#4828 Since this is a scaffold project, I think we should just delete the lock file so that the install can build for the user's platform. The next error I encountered is that there's no custom theme in scaffold and the biome config expects that, so this might be something we want to document.
|
Summary
Uses Biome in place of ESLint and Prettier (this reduces the number of packages needed and avoids having to adapt to breaking changes in new version of ESLint). To support this change, ddev config is also updated to use a newer version of Node and the package.lock also needed to be rebuilt and all the packages updated. The required packages in Composer were also updated.
Metadata
CHANGELOG
reflects changes?