Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing test keys #491

Merged
merged 4 commits into from
Sep 30, 2020
Merged

Handle missing test keys #491

merged 4 commits into from
Sep 30, 2020

Conversation

sarathms
Copy link
Contributor

@sarathms sarathms commented Sep 18, 2020 •
edited
Loading

Fixes #416

Makes sure all measurement pages render without crashing when any of the keys in test_keysare not found in the measurement.

Also includes a development toolbar (not added to any pages) that allows us to control the values inside different test_keys
image

@sarathms sarathms marked this pull request as ready for review September 18, 2020 20:53
bassosimone
bassosimone approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I really like what I see. Please, consider applying the recommended changes, which mainly amount to tiny changes to slightly improve reliability. 🐳

components/measurement/nettests/HTTPHeaderFieldManipulation.js Outdated Show resolved Hide resolved
components/measurement/nettests/HTTPHeaderFieldManipulation.js Outdated Show resolved Hide resolved
components/measurement/nettests/Ndt.js Show resolved Hide resolved
components/measurement/useTestKeyController.js Outdated Show resolved Hide resolved
components/measurement/useTestKeyController.js Show resolved Hide resolved
@sarathms sarathms self-assigned this Sep 30, 2020
@sarathms sarathms added this to the Sprint 23 - Ægir milestone Sep 30, 2020
@sarathms
Copy link
Contributor Author

I have addressed the comments. I made a small change that makes it easy to follow the usage described here. Since it is a trivial one, I am going ahead and merging this.

@sarathms sarathms merged commit cd702b8 into master Sep 30, 2020
@sarathms sarathms deleted the fix/handle-missing-testKeys branch September 30, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

Assignees

@sarathms sarathms

Labels
None yet
Projects
None yet
Milestone
Sprint 23 - Ægir
Development

Successfully merging this pull request may close these issues.

Ensure pages render minimal content when test_keys are missing
2 participants
@sarathms @bassosimone