tests: adapt integration tests to run against the refactored code #33
ainghazalbuild-refactor.yml
on: pull_request
short-tests
10m 16s
lint
3s
gosec
37s
coverage-threshold
10m 19s
integration
17s
Annotations
6 errors and 10 warnings
|
integration:
tests/integration/openvpn_test.go#L128
undefined: model.NewConfig
|
|
integration:
tests/integration/openvpn_test.go#L128
undefined: model.WithConfigFile
|
|
integration:
tests/integration/openvpn_test.go#L136
not enough arguments in call to tun.StartTUN
|
|
integration
Process completed with exit code 1.
|
|
short-tests
Process completed with exit code 1.
|
|
coverage-threshold
Process completed with exit code 2.
|
|
lint:
internal/optional/optional.go#L1
should have a package comment
|
|
lint:
internal/bytesx/bytesx.go#L38
comment on exported function GenRandomBytes should be of the form "GenRandomBytes ..."
|
|
lint:
internal/bytesx/bytesx.go#L115
comment on exported function BytesPadPKCS7 should be of the form "BytesPadPKCS7 ..."
|
|
lint:
internal/controlchannel/controlchannel.go#L1
should have a package comment
|
|
lint:
internal/session/manager.go#L23
comment on exported const S_UNDEF should be of the form "S_UNDEF ..."
|
|
lint:
internal/session/manager.go#L17
type name will be used as session.SessionNegotiationState by other packages, and that stutters; consider calling this NegotiationState
|
|
lint:
internal/packetmuxer/service.go#L193
should replace ws.hardResetCount += 1 with ws.hardResetCount++
|
|
lint:
internal/session/manager.go#L229
exported var ErrExpiredKey should have comment or be unexported
|
|
lint:
internal/session/manager.go#L164
comment on exported method Manager.NewACKForPacketIDs should be of the form "NewACKForPacketIDs ..."
|
|
lint:
internal/session/manager.go#L21
don't use ALL_CAPS in Go names; use CamelCase
|