tests: adapt integration tests to run against the refactored code #75
ainghazalbuild-refactor.yml
on: pull_request
short-tests
15s
lint
4s
gosec
41s
coverage-threshold
10s
integration
11s
Annotations
10 warnings
|
lint:
internal/session/manager.go#L173
exported var ErrExpiredKey should have comment or be unexported
|
|
lint:
internal/session/manager.go#L108
comment on exported method Manager.NewACKForPacketIDs should be of the form "NewACKForPacketIDs ..."
|
|
lint:
internal/bytesx/bytesx.go#L115
comment on exported function BytesPadPKCS7 should be of the form "BytesPadPKCS7 ..."
|
|
lint:
internal/session/manager.go#L252
exported method Manager.CurrentKeyID should have comment or be unexported
|
|
lint:
internal/session/manager.go#L142
if block ends with a return statement, so drop this else and outdent its block
|
|
lint:
internal/bytesx/bytesx.go#L38
comment on exported function GenRandomBytes should be of the form "GenRandomBytes ..."
|
|
lint:
internal/datachannel/write.go#L69
parameter 'log' seems to be unused, consider removing or renaming it as _
|
|
lint:
internal/datachannel/write.go#L20
parameter 'log' seems to be unused, consider removing or renaming it as _
|
|
lint:
internal/datachannel/read.go#L16
parameter 'log' seems to be unused, consider removing or renaming it as _
|
|
lint:
internal/datachannel/read.go#L32
don't use underscores in Go names; var packet_id should be packetID
|