Skip to content

refactor: remove legacy package #300

refactor: remove legacy package

refactor: remove legacy package #300

Triggered via pull request March 6, 2024 18:53
Status Failure
Total duration 47s
Artifacts

build.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 10 warnings
short-tests: internal/tlssession/tlshandshake_test.go#L18
no required module provides package github.com/ooni/minivpn/vpn/mocks; to add it:
short-tests
Process completed with exit code 1.
coverage-threshold: internal/tlssession/tlshandshake_test.go#L18
no required module provides package github.com/ooni/minivpn/vpn/mocks; to add it:
coverage-threshold
Process completed with exit code 2.
lint: internal/bytesx/bytesx.go#L115
comment on exported function BytesPadPKCS7 should be of the form "BytesPadPKCS7 ..."
lint: internal/bytesx/bytesx.go#L38
comment on exported function GenRandomBytes should be of the form "GenRandomBytes ..."
lint: internal/runtimex/runtimex_test.go#L13
parameter 't' seems to be unused, consider removing or renaming it as _
lint: internal/mocks/addr.go#L1
should have a package comment
lint: internal/model/packet_test.go#L380
parameter 't' seems to be unused, consider removing or renaming it as _
lint: internal/model/mocks.go#L5
exported type TestLogger should have comment or be unexported
lint: internal/networkio/networkio_test.go#L83
parameter 'ctx' seems to be unused, consider removing or renaming it as _
lint: internal/tlssession/tlsbio_test.go#L12
parameter 't' seems to be unused, consider removing or renaming it as _
lint: internal/tlssession/tlshandshake_test.go#L524
parameter 't' seems to be unused, consider removing or renaming it as _
lint: internal/tlssession/tlshandshake.go#L161
parameter 'verifiedChains' seems to be unused, consider removing or renaming it as _