Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add utility script to convert pcap into test sequence #62

Merged
merged 8 commits into from
Feb 8, 2024

Conversation

ainghazal
Copy link
Collaborator

Checklist

  • I have read the contribution guidelines
  • Iff you changed code related to services, or inter-service communication, make sure you update the diagrams in ARCHITECTURE.md.
  • Reference issue for this pull request:

Description

Add an utility script to convert a pcap containing a reference OpenVPN handshake into a string containing a compact representation of the packet exchange that can be later used for writing unit tests.

@ainghazal ainghazal requested a review from bassosimone February 6, 2024 12:35
@ainghazal ainghazal self-assigned this Feb 6, 2024
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the applied suggestions

scripts/get_trace_from_pcap.py Show resolved Hide resolved
ainghazal and others added 2 commits February 8, 2024 18:34
Co-authored-by: Simone Basso <bassosimone@gmail.com>
@ainghazal ainghazal merged commit c74c9a3 into ooni:main Feb 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants