tests: add tests for reliable service under packet loss #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ainghazal
changed the title
|
I think this is ready for review. the only file of interest after merging #60 should be https://github.com/ooni/minivpn/pull/63/files#diff-b9a3711895939a4f4dc918dccb1b8e3eda12d2fea35a79984d7a7a7aab12a9a3 (modulo any minor changes) |
ainghazal
commented
Feb 7, 2024
bassosimone
reviewed
Feb 8, 2024
| log.SetLevel(log.DebugLevel) | ||
| if testing.Verbose() { | ||
| log.SetLevel(log.DebugLevel) | ||
| } |
bassosimone
approved these changes
Feb 8, 2024
Co-authored-by: Simone Basso <bassosimone@gmail.com>
Co-authored-by: Simone Basso <bassosimone@gmail.com>
Co-authored-by: Simone Basso <bassosimone@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
ARCHITECTURE.md.Description
Exercise reliable service passing a vector of packet ID to simulate packet loss.
Additionally, this PR updates github actions version to the latest action release for checkout (v4) and setup-go (v5). Eventually, we'll currently replace the test setup with the one we're using to run tests on the internal packages.
TODO: This PR needs to be rebased on top of #60