Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Inconsistent behavior opening preference intent screens. #591

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Fix: Inconsistent behavior opening preference intent screens. #591

merged 1 commit into from
Sep 10, 2023

Conversation

aanorbel
Copy link
Member

@aanorbel aanorbel commented Aug 1, 2023

Related to ooni/probe#1989

Proposed Changes

  • Updates intents in preferences to target class and package for consistent behavior across various application flavors.

@aanorbel
Updates intents in preferences to target class and package for consis…
7e0b657 
…tent behaviour across various application flavors.
@aanorbel aanorbel requested review from bassosimone and hellais August 1, 2023 10:50
bassosimone
bassosimone approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@aanorbel aanorbel merged commit 907aa0d into master Sep 10, 2023
@aanorbel aanorbel deleted the issue/1989-update branch September 10, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

@hellais hellais Awaiting requested review from hellais

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aanorbel @bassosimone