Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Update RunningActivity to ViewBinding #592

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Chore: Update RunningActivity to ViewBinding #592

merged 1 commit into from
Sep 10, 2023

Conversation

aanorbel
Copy link
Member

@aanorbel aanorbel commented Aug 3, 2023

Related to ooni/probe#1709

Proposed Changes

  • Replace Butterknife

@aanorbel aanorbel requested review from bassosimone and hellais August 3, 2023 09:22
hellais
hellais reviewed Aug 7, 2023
View reviewed changes
Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing, but LGTM

bassosimone
bassosimone approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@aanorbel aanorbel merged commit 41eb5f5 into master Sep 10, 2023
1 check passed
@aanorbel aanorbel deleted the chore/running-activity-upgrade-to-view-binding branch September 10, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais hellais left review comments

@bassosimone bassosimone bassosimone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aanorbel @bassosimone @hellais