Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Optionally group results #613

Merged
merged 9 commits into from
Dec 5, 2023
Merged

Feat: Optionally group results #613

merged 9 commits into from
Dec 5, 2023

Conversation

aanorbel
Copy link
Member

@aanorbel aanorbel commented Sep 3, 2023 •
edited
Loading

Proposed Changes

  • Convert ResultDetailActivity to Kotlin.
  • Remove HeterogeneousRecyclerAdapter and replace it with BaseExpandableListAdapter
  • Use a single xml file to capture the view as opposed to the 2 used with HeterogeneousRecyclerAdapter
  • Deprecate MeasurementPerfItem and MeasurementItem
Collapsed group of items Collapsed Item and Expanded group Grouped and non-group items display
Screenshot_20230904_110024 Screenshot_20230904_110034 Screenshot_20230904_115620
Ungrouped items since just one test Support for Different item type
Screenshot_20230903_093549 Screenshot_20230903_093601

Base automatically changed from issues/1709/result-detail-activity to master September 11, 2023 12:59
@aanorbel aanorbel marked this pull request as draft September 12, 2023 11:10
@aanorbel aanorbel changed the base branch from master to chore/gradle-kotlin-upgrade October 31, 2023 18:34
@aanorbel
Copy link
Member Author

. .
Screenshot_20231031_193322 Screenshot_20231031_193336?

@aanorbel aanorbel marked this pull request as ready for review October 31, 2023 18:37
@aanorbel aanorbel changed the base branch from chore/gradle-kotlin-upgrade to master October 31, 2023 18:39
@aanorbel aanorbel changed the base branch from master to chore/gradle-kotlin-upgrade October 31, 2023 18:39
Base automatically changed from chore/gradle-kotlin-upgrade to master November 3, 2023 07:33
@bassosimone
Copy link
Contributor

This is lovely!

bassosimone
bassosimone approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@aanorbel aanorbel merged commit 3b27a17 into master Dec 5, 2023
4 of 5 checks passed
@aanorbel aanorbel deleted the feat/optionally-group-results branch December 5, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

@hellais hellais Awaiting requested review from hellais

@agrabeli agrabeli Awaiting requested review from agrabeli

@jbonisteel jbonisteel Awaiting requested review from jbonisteel

@sloncocs sloncocs Awaiting requested review from sloncocs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aanorbel @bassosimone