Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Moved riseup vpn to experimental suite and correct tests #625

Merged
merged 16 commits into from
Dec 5, 2023
Merged

Chore: Moved riseup vpn to experimental suite and correct tests #625

merged 16 commits into from
Dec 5, 2023

Conversation

aanorbel
Copy link
Member

@aanorbel aanorbel commented Oct 20, 2023 •
edited
Loading

Proposed Changes

  • Move riseupvpn to experimental suite
  • Correct tests appropriately.
. .
Screenshot_20231124_201232 Screenshot_20231124_201328

aanorbel and others added 12 commits October 11, 2023 11:56
@aanorbel
chore: use probe-cli v3.20.0-alpha
f0567b8
@aanorbel
Updated dependency
4978665
@aanorbel
Merge branch 'master' of github.com:ooni/probe-android into issues/2524
5876adf
@aanorbel
Updated experimental tests and added echeck ooni/probe#2567
e8c97c7
@aanorbel
Updates test runner to append error messages if morethan one is recie…
207e77d 
…ved from the `CLI`
@aanorbel
Updates Overviewactivity copy for experimental tests.
4d4f686
@aanorbel
Updates experimental test suite
2295890
@aanorbel
Updated circumventiont suite test
5336624
@aanorbel
Feat: Add support for http and https proxies (#623)
ef361e4 
Fixes  ooni/probe#2561

## Proposed Changes

- Update support for socks proxy to use dropdown for selecting a scheme.
- Update code to save and retrieve the various proxies.


![Screenshot_20231013_171055](https://github.com/ooni/probe-android/assets/17911892/2bad783f-6570-478d-9754-f07a17184664)
@aanorbel
Updated engine version
b8b5dd3
@aanorbel
Merge branch 'master' of github.com:ooni/probe-android into issues/2524
69cc503
@aanorbel
Moved riseup vpn to experimental suite and correct tests
0d4037d
@aanorbel aanorbel mentioned this pull request Oct 20, 2023
Merged
@aanorbel aanorbel marked this pull request as ready for review October 20, 2023 10:20
Base automatically changed from issues/2524 to master October 20, 2023 14:51
@aanorbel aanorbel requested a review from bassosimone November 27, 2023 07:35
bassosimone
bassosimone approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🐳

I have only a minor suggestion: linking this PR or a reference issue into the comment that explains why riseupvpn has been demoted.

app/src/main/java/org/openobservatory/ooniprobe/test/test/RiseupVPN.java Outdated Show resolved Hide resolved
@aanorbel aanorbel merged commit e1b88e9 into master Dec 5, 2023
7 of 8 checks passed
@aanorbel aanorbel deleted the chore/move-riseupvpn-to-experimental branch December 5, 2023 13:04
aanorbel added a commit that referenced this pull request Jan 9, 2024
@aanorbel
Modified CircumventionTest to remove riseupvpn related tests sinc…
f61d38e 
…e it status changed in #625
@aanorbel aanorbel mentioned this pull request Jan 9, 2024
Merged
aanorbel added a commit that referenced this pull request Jan 18, 2024
@aanorbel
fix: failing tests (#651)
8d78f27 
# Proposed Changes
- Modified `CircumventionTest` to remove `riseupvpn` related tests since
its status changed in #625
- Updated tests for ExpandableListView to use proper methods.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bassosimone bassosimone bassosimone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aanorbel @bassosimone