Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (OONI Run v2): Change backend for fetching descriptors #713

Merged
merged 7 commits into from
Apr 9, 2024

Conversation

aanorbel
Copy link
Member

@aanorbel aanorbel commented Apr 2, 2024

Proposed Changes

  • Change the backend for fetching descriptors and refactor code appropriately.

@aanorbel aanorbel requested review from bassosimone and hellais April 2, 2024 16:05
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff reads correct to me. I have added a bunch of small comments that I'd like you to apply. After that, please feel free to merge! 🙏

aanorbel and others added 4 commits April 9, 2024 10:12
…oardAdapter.kt

Co-authored-by: Simone Basso <bassosimone@gmail.com>
…UpdateDescriptorsWorker.kt

Co-authored-by: Simone Basso <bassosimone@gmail.com>
…/TestDescriptor.kt

Co-authored-by: Simone Basso <bassosimone@gmail.com>
…fig.java

Co-authored-by: Simone Basso <bassosimone@gmail.com>
@aanorbel aanorbel merged commit 50448c9 into dev/ooni-run-v2 Apr 9, 2024
2 checks passed
@aanorbel aanorbel deleted the dev/ooni-run-v2-api-refactor branch April 9, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants