Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec(openvpn): ensure that the semantics of bootstrap_time are consistent between tunnel experiments #2758

Open
ainghazal opened this issue Jun 25, 2024 · 0 comments
Assignees
Labels
bug Something isn't working priority/high

Comments

@ainghazal
Copy link

ainghazal commented Jun 25, 2024

During a review we noticed that the semantics of bootstrap_time in the current openvpn spec might not be exactly compatible with psiphon or Tor.

This needs to be revisited, ideally before next release window.
For consistence, the easy thing to do seems to be to include the total time to bootstrap, and define this field so that it is not included in the case of an error.

However, a valid point still holds about capturing timing of handshake packets in the case of OpenVPN. This can be added as handshake time - the rationale is that further use of the tunnel will add complexity for analysis to extract timing info from the network_events array.

max_runtime could also be added to be sure that we're analyzing equivalent timeout times.

@ainghazal ainghazal added bug Something isn't working triage labels Jun 25, 2024
DecFox pushed a commit to ooni/probe-cli that referenced this issue Jul 19, 2024
…hake failure (#1632)

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
ooni/probe#2758
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request:
ooni/spec#295
- [x] if you changed code inside an experiment, make sure you bump its
version number


## Description

Add `bootstrap_time` as a top-level test-key, making OpenVPN nettest
conforming to `df-009-tunnel`. It also adds `tunnel` and `failure` keys
with the semantics declared in that spec.
DecFox pushed a commit to ooni/spec that referenced this issue Jul 19, 2024
## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/spec/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
ooni/probe#2758
- [ ] related ooni/probe-cli pull request: <!-- add URL here -->
- [x] If I changed a spec, I also bumped its version number and/or date


## Description

Modify spec to comply with the semantics of df-009-tunnel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/high
Projects
None yet
Development

No branches or pull requests

2 participants