Skip to content

Commit

Permalink
[player-7012] The clickthrough url is not a url that we need to ping.…
Browse files Browse the repository at this point in the history
… It's just the url we need to open. So I'm taking out any code that uses that url (that isn't the line of code that opens the new tab).
  • Loading branch information
pilievOoyala committed Jan 18, 2018
1 parent 96547a3 commit 2aa2bff
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions js/ad_manager_vast.js
Original file line number Diff line number Diff line change
Expand Up @@ -1159,12 +1159,6 @@ OO.Ads.manager(function(_, $) {
linearClickTrackingUrls = linearClickTrackingUrls.concat(vastAdObject.linear.clickTracking);
}

if (vastAdObject.linear &&
vastAdObject.linear.clickThrough &&
vastAdObject.linear.clickThrough.length > 0) {
linearClickTrackingUrls = linearClickTrackingUrls.concat(vastAdObject.linear.clickThrough);
}

if (vastAdObject.linear &&
vastAdObject.linear.customClick &&
vastAdObject.linear.customClick.length > 0) {
Expand Down Expand Up @@ -1787,7 +1781,6 @@ OO.Ads.manager(function(_, $) {
}
var newWindow = window.open(url);
newWindow.opener = null;
newWindow.location = url;
return true;
};

Expand Down

0 comments on commit 2aa2bff

Please sign in to comment.