Object.assign() on not-so-old nwjs #111
Labels
Comments
This was referenced Mar 26, 2016
|
This should do it: 9972cff Thank you |
tlancina
added a commit
to ionic-team/ionic-app-lib
that referenced
this issue
Mar 30, 2016
Verison of xml2js we were on had a very broad semver range for its dependency on xmlbuilder, which has had several breaking changes. Update to narrow that range. Related: oozcitak/xmlbuilder-js#111.
tlancina
added a commit
to ionic-team/ionic-app-lib
that referenced
this issue
Mar 31, 2016
Verison of xml2js we were on had a very broad semver range for its dependency on xmlbuilder, which has had several breaking changes. Update to narrow that range. Related: oozcitak/xmlbuilder-js#111.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
Your new versions (I use 4.x normally) aren't compatible with nwjs 0.12.3, because of the
Object.assign()in "create" method.May I suggest you to use a polyfill (plain or as a dep) to allow support of a little older platforms?
I'll PR 2 different possibilities to solve the matter, if you like one of them and are OK with supporting a greater range of platforms, please merge it :)
Thanks!
The text was updated successfully, but these errors were encountered: