chore(mpt): Noop Provider Refactor #645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
added
K-chore
refcell
force-pushed
the
rf/feat/mpt-noop-provider-refactor
branch
from
27c25e3 to
085bdeb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files☔ View full report in Codecov by Sentry. |
clabby
requested changes
Oct 7, 2024
|
|
||
| /// The default, no-op implementation of the [TrieHinter] trait, used for testing. | ||
| #[derive(Debug, Clone, Copy)] | ||
| pub struct NoopTrieHinter; |
There was a problem hiding this comment.
I don't think these belong in test utils unfortunately. Succinct and other downstream implementers use this - non FPVM targets don't have hints.
There was a problem hiding this comment.
Specifically the hinter - if we really want to we can keep the provider behind the test utils, but may as well also distribute it if we have the noop hinter distributed.
|
Replaced by #649 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pulls
Noopprovider and hinter into thetest-utilsfeat flag.This increases code coverage % since these noop impls were not, and don't need to be covered as they are test utilities, shared by the benchmark code.