Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(derive): Holocene action tests / fixes #733

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Oct 24, 2024

Overview

This PR updates the action tests in kona to the latest version of the monorepo. It also contains small fixes. If throughout getting action tests updated, there are bigger issues, I'll stack the fixes on top of this PR.

@clabby clabby requested a review from refcell as a code owner October 24, 2024 19:00
@clabby
Copy link
Collaborator Author

clabby commented Oct 24, 2024

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

@clabby clabby marked this pull request as draft October 24, 2024 19:00
@clabby clabby added A-ci Area: CI A-derive Area: kona-derive crate K-fix Kind: fix H-holocene Hardfork: Holocene related labels Oct 24, 2024
@clabby clabby self-assigned this Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@330deeb). Learn more about missing BASE report.
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby marked this pull request as ready for review October 25, 2024 18:27
justfile Show resolved Hide resolved
justfile Show resolved Hide resolved
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions, but otherwise changes look good

@clabby clabby added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 938805a Oct 25, 2024
17 checks passed
This was referenced Oct 25, 2024
fakedev9999 pushed a commit to fakedev9999/kona that referenced this pull request Nov 5, 2024
* fix(derive): Support modern action tests + holocene fixes

* update commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: CI A-derive Area: kona-derive crate H-holocene Hardfork: Holocene related K-fix Kind: fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants