nit(mpt): Remove unnecessary collapse_if_possible
call
#808
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aim of this PR is to remove a very subtle yet unused
unblind
call to prevent access to unused trie nodes. Such additional access, while having minor performance impact, prevents the delegation of execution witness generation to external clients that retrieve the minimum required trie nodes, such as zeth.The PR modifies
collapse_if_possible
to avoid attempting to collapse the blinded child of an extension node. The reason is that because we assume the trie is correctly constructed prior to any execution, there is no need to unblind the child of the extension (which must be a branch) to attempt further collapse, because the execution did not unblind this child already and therefore did not perform any reads/writes to it.