Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fraemwork #862

Closed
Closed

Conversation

bxue-l2
Copy link

@bxue-l2 bxue-l2 commented Dec 3, 2024

No description provided.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 1.81818% with 54 lines in your changes missing coverage. Please review.

Project coverage is 89.8%. Comparing base (8bbbc6b) to head (88df25b).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/derive/src/sources/eigenda_blobs.rs 0.0% 37 Missing ⚠️
crates/derive/src/sources/eigenda.rs 0.0% 14 Missing ⚠️
crates/derive/src/sources/eigenda_data.rs 0.0% 3 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell
Copy link
Collaborator

refcell commented Dec 3, 2024

Kona is built so that trait abstractions provide a way to add new implementations through separate crates. The changes you've made here should go in a new crate, in a new repository that pulls in kona crates as dependencies. This way, new implementations don't need to be merged into kona, but can live outside of the kona repository while still building ontop of kona. See hilo for example, which pulls in kona-derive and kona-driver as dependencies, and builds off the trait abstractions in kona to use the derivation pipeline and driver.

@bxue-l2 bxue-l2 closed this Dec 3, 2024
@bxue-l2
Copy link
Author

bxue-l2 commented Dec 3, 2024

Hi refcell, I intended to upstream this change to my fork for others to review, but made a mistake to upstream here, sorry about it. Thanks so much for giving feedbacks. Will take a look at the example you gave.

@refcell
Copy link
Collaborator

refcell commented Dec 3, 2024

Hi refcell, I intended to upstream this change to my fork for others to review, but made a mistake to upstream here, sorry about it. Thanks so much for giving feedbacks. Will take a look at the example you gave.

Oh no worries at all, if there is a change you'd like to make to any of the trait abstractions or internal pipeline/proofs logic please do open a pr here!!

@samlaf
Copy link
Contributor

samlaf commented Dec 3, 2024

@refcell are you picturing a world where every altda layer has their own hilo-like crate in their own repo? Or one where there's a single altda crate as part of anton-rs where all the altda providers would upstream their integration?

Also might be good to update the altda section of the book to point to hilo. Should we open an issue to discuss the different architectures possible and to try to sync between the different altda teams?

@samlaf samlaf mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants