-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fraemwork #862
add fraemwork #862
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files☔ View full report in Codecov by Sentry. |
Kona is built so that trait abstractions provide a way to add new implementations through separate crates. The changes you've made here should go in a new crate, in a new repository that pulls in kona crates as dependencies. This way, new implementations don't need to be merged into kona, but can live outside of the kona repository while still building ontop of kona. See hilo for example, which pulls in |
Hi refcell, I intended to upstream this change to my fork for others to review, but made a mistake to upstream here, sorry about it. Thanks so much for giving feedbacks. Will take a look at the example you gave. |
Oh no worries at all, if there is a change you'd like to make to any of the trait abstractions or internal pipeline/proofs logic please do open a pr here!! |
@refcell are you picturing a world where every altda layer has their own hilo-like crate in their own repo? Or one where there's a single altda crate as part of anton-rs where all the altda providers would upstream their integration? Also might be good to update the altda section of the book to point to hilo. Should we open an issue to discuss the different architectures possible and to try to sync between the different altda teams? |
No description provided.