Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tooling: make client justfile's commands take an optional rollup_config_path #869

Conversation

samlaf
Copy link
Contributor

@samlaf samlaf commented Dec 11, 2024

Needed to target a devnet which doesnt have a standard chain_id. Might need to make the same change for the offline client target as well?

We use this to test the client against the docker devnet in op's monorepo:

# Run the client program natively with the host program attached, against the op-devnet.
run-client-native-against-devnet verbosity='' block_number='' rollup_config_path='':
  #!/usr/bin/env bash
  L1_RPC="http://127.0.0.1:8545"
  L1_BEACON_RPC="http://127.0.0.1:5052"
  L2_RPC="http://127.0.0.1:9545"
  ROLLUP_NODE_RPC="http://127.0.0.1:7545"
  ROLLUP_CONFIG_PATH="../../../optimism/.devnet/rollup.json"

  if [ -z "{{block_number}}" ]; then
    BLOCK_NUMBER=$(cast block finalized --json --rpc-url $L2_RPC | jq -r .number | cast 2d)
  else
    BLOCK_NUMBER={{block_number}}
  fi

  just run-client-native $BLOCK_NUMBER \
    $L1_RPC $L1_BEACON_RPC $L2_RPC $ROLLUP_NODE_RPC \
    $ROLLUP_CONFIG_PATH {{verbosity}}

…ig_path

Needed to target a devnet which doesnt have a standard chain_id
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@clabby clabby added this pull request to the merge queue Dec 12, 2024
Merged via the queue into op-rs:main with commit 8f21eff Dec 12, 2024
16 checks passed
@samlaf samlaf deleted the tooling/run-client-native-takes-optional-rollup-config-arg branch December 13, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants